Conversation
Collaborator
Author
|
I fixed issues with regard to RN template using Yarn 3.6.4 by default. @tomekzaw @piaskowyk Could you take a look at the failing V8 and monorepo CIs? I have the following questions.
Which doesn't make a lot of sense - creating the EDIT: Thanks for discussing it with me offline. |
13 tasks
piaskowyk
approved these changes
May 15, 2024
tjzel
added a commit
that referenced
this pull request
Jun 5, 2024
## About This pull request is a part of the effort of migrating to monorepo structure: - #5992 ## Summary Moving `.github` directory to the root of the project, alongside with fixes that regard new repository structures. This pull request won't fix CIs which are being tackled in - #5996 ## Test plan No CI should fail on a step related to the change of the monorepo structure. ## Steps achieved towards monorepo - [ ] All CI pass - [ ] Precommit scripts work properly - [ ] react-native-reanimated is a separate workspace which uses hoisted node_modules - [ ] app is a separate workspace which uses hoisted node_modules - [ ] paper example is a separate workspace which uses hoisted node_modules - [ ] fabric example is a separate workspace which uses hoisted node_modules - [ ] web example is a separate workspace which uses hoisted node_modules - [ ] macos example is a separate workspace which uses hoisted node_modules - [ ] example is a separate workspace which uses hoisted node_modules - [ ] reanimated eslint plugin is a separate workspace which uses hoisted node_modules - [ ] the npm package builds and works as expected - [ ] reanimated2 directory is removed - [ ] TypeScript, ESLint and Prettier configs are unified and only extended when necessary in workspaces
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Due to changes to React Native app template, it uses Yarn 3.6.4 out of the box now. This version of Yarn cannot resolve packages from GitHub's pull request refs. Therefore we have to resolve it for it and install via a downloaded package. It's not something crazy - Yarn 1 would do exactly those steps.
Test plan
Should not fail on the dependency installing steps with yarn. Ideally, they shouldn't fail at all.